Fix profiling with tracy. #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The profiling APIs require a `&str`, but since the label here is now an `Option<String>`, we must get a `&str` from it.
waywardmonkeys
force-pushed
the
fix-profiling-with-tracy
branch
from
41a6fc8
to
6a82239
Compare
|
This should get something added to test it in CI to prevent future breakage. |
|
good candidate for a patch release |
This was referenced Jul 19, 2024
cwfitzgerald
added
the
PR: needs back-porting
|
Can we expect a lil patch release with this in it sometime in the near future? 👀 |
|
Yeah, hopefully within the week |
|
continued inquiring look 👀 |
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Jul 31, 2024
The profiling APIs require a `&str`, but since the label here is now an `Option<String>`, we must get a `&str` from it. (cherry picked from commit 20973d1) # Conflicts: # CHANGELOG.md
|
Yay! ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Building with tracy support results in a compilation error.
The profiling APIs require a
&str, but since the label here is now anOption<String>, we must get a&strfrom it.Testing
It builds now.
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.